Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix status bar clipped in minimal state #1517

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Fix status bar clipped in minimal state #1517

merged 1 commit into from
Oct 7, 2022

Conversation

r3inbowari
Copy link
Contributor

@r3inbowari r3inbowari commented Oct 4, 2022 •
edited
Loading

Motivation

Fix bottom status bar(or top tool bar when click the output title) is clipped by allowing the DockPanel has a wider height range.

Change description

Make the total height of the split children less than the preset minHeight as much as possible.

Other information

Related to #1515 #1151 #779 #662

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos self-requested a review October 4, 2022 06:16
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 4, 2022
AlbyIanna
AlbyIanna approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

This also fixes the sidenav scrolling.

Before change:

Screen.Recording.2022-10-04.at.15.27.10.mov

After change:

Screen.Recording.2022-10-04.at.15.27.43.mov

Thank you so much for you contribution @r3inbowari! It is really appreciated 🤗

@per1234 per1234 linked an issue Oct 6, 2022 that may be closed by this pull request
As a user, I want to resize the Monitor output view smaller than 10 lines #308
Closed
per1234
per1234 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified it fixes #1515 and #662 when used with any reasonable combination of window size and scale values (they can still occur when the vertical window size is ridiculously small and the scale value ridiculously large, but the IDE UI in general will be unusable under those conditions so we don't need to be concerned about it).

Thanks @r3inbowari!

@r3inbowari
Copy link
Contributor Author

r3inbowari commented Oct 6, 2022 •
edited
Loading

(they can still occur when the vertical window size is ridiculously small and the scale value ridiculously large, but the IDE UI in general will be unusable under those conditions so we don't need to be concerned about it).

That's right, unless the minHeight is zero.

@AlbyIanna AlbyIanna merged commit 1e269ac into arduino:main Oct 7, 2022
@per1234 per1234 linked an issue Oct 7, 2022 that may be closed by this pull request
Top part of UI disappears when opening recent sketch #1515
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@kittaakos kittaakos Awaiting requested review from kittaakos

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
4 participants
@r3inbowari @AlbyIanna @per1234 @kittaakos